Return to Starling Playback Library

ZipToGAFAssetConverter cannot be reused

Questions related to Starling playback library should be asked here.

ZipToGAFAssetConverter cannot be reused

Postby Nicolas Bousquet » September 28th, 2015, 5:34 am

Hi there,

Not really a bug, but since I'm trying to limit the instanciation, I decided to instanciate the converter once and keep a reference to it for latter use.
If I load a zip and feed it to the converter, then unload the module, then reload the module and try to feed the same zip to the converter (since I'm not supposed to keep a reference to the zip itself, I could be loading another module entirely) it crashes when parsing assets.
This is because I did not find a way to reset ZipToGAFAssetConverter.currentConfigIndex.
I avoided the bug by creating a new instance for every conversion but maybe it would be nice to be able to reuse it after a calling a reset method.
User avatar
Nicolas Bousquet
 
Posts: 9
Joined: September 10th, 2015, 6:11 am

Re: ZipToGAFAssetConverter cannot be reused

Postby vadym.mitin » September 28th, 2015, 6:32 am

Hi,

We will have a look on the ZipToGAFAssetConverter. If we will not find any issues with reusable ZipToGAFAssetConverter - we will make it reusable. I will post an update here.
User avatar
vadym.mitin
 
Posts: 254
Joined: December 4th, 2013, 8:00 am

Re: ZipToGAFAssetConverter cannot be reused

Postby Ivan Avdeenko » September 28th, 2015, 8:21 am

Hi. We did it. Now ZipToGafAssetConverter is reusable. Please, check it out in master.
User avatar
Ivan Avdeenko
 
Posts: 30
Joined: June 6th, 2014, 12:22 am

Re: ZipToGAFAssetConverter cannot be reused

Postby Nicolas Bousquet » September 28th, 2015, 11:17 pm

Wow, you guys seriously rock.
Thanks for the update, I'll head out to Github to check this out.
User avatar
Nicolas Bousquet
 
Posts: 9
Joined: September 10th, 2015, 6:11 am

Re: ZipToGAFAssetConverter cannot be reused

Postby Nicolas Bousquet » September 28th, 2015, 11:20 pm

Ok, so every call to the convert method will reset the parameters. Works for me.
Thanks again guys.
User avatar
Nicolas Bousquet
 
Posts: 9
Joined: September 10th, 2015, 6:11 am

Return to Starling Playback Library

Who is online

Users browsing this forum: No registered users and 2 guests